Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Generalization refactorings #6

Open
wants to merge 84 commits into from
Guilherme Blanco

Hi ServerGrove team,

My team have worked hard to turn this extension much more usable in a various ways.
Some enhancements are very good, but we had to drop ODM support for now since the team won't be using it, but we did our best to turn into very extendable and reusable for other mappings.
Here is a list of enhancements:

  • Add Locale
  • Drop Locale
  • New entries now supports Domain and File
  • ORM support
  • XLIFF support

We hope you like it! =)

Regards,

Guilherme Blanco on behalf of InstaClick Inc.

and others added some commits February 07, 2012
Guilherme Blanco Initial efforts around conversion from MongoDB specific to Storage ag…
…nostic (but implementing ORM as default).
146c1f7
Guilherme Blanco Added missing field to Entry. 558e3e8
Guilherme Blanco Refactored services initialization for consistency with Symfony stand…
…ards.
6a994aa
Juti Noppornpitak Refactored the code. (This commit will break YML import.) daa3dc0
Juti Noppornpitak Laid out the code to support Xliff files with ORM. 3dc3fd9
Guilherme Blanco Several fixes to entities and also initial efforts on controller. 13f3669
Juti Noppornpitak Refactored the code ready for integrating with ORM. 08e052c
Guilherme Blanco Merge branch 'master' of github.com:instaclick/TranslationEditorBundle ff52dea
Guilherme Blanco More work around ImportCommand. 2231ef2
Juti Noppornpitak Added createLocale and updated the variable referencing AppKernel. 07d1827
Guilherme Blanco Finished import command. Still need to test if UTF-8 chars are import…
…ed correctly.
f331db8
Guilherme Blanco Refactored frontend. Most actions are working (except the new transla…
…tion).
af5f151
Juti Noppornpitak Refactored the code from ImportCommand to Base; finished the coding t…
…o analyze, classify the translation and rendered into a string in ExportCommand. Please note that ExportCommand in this commit cannot write a file.
c07430c
Juti Noppornpitak Refactored the XLIFF file handler from the export command and make th…
…e file handler as a service.
82a63d0
Guilherme Blanco Finished changes in Import and Export Commands. Now they are complete…
…ly isolated.
ef2d950
Guilherme Blanco Optimized ORMStorage and also added missing methods on StorageInterfa…
…ce. Also, moved ObjectManager compatible code to AbstractStorage.
959a36d
Guilherme Blanco Made new entry works. 269777c
Guilherme Blanco Improved reusabiity of Importers. Added YamlImporter. 73cbf3b
Guilherme Blanco Committed missing file 483a79d
Guilherme Blanco Added YAML Exporter. 2257daa
Guilherme Blanco Added support to create and drop locales dynamically. fd8dfe2
Guilherme Blanco Turned domain into a drop down list. 7ba43b2
Guilherme Blanco {{@inheritdoc}} => {@inheritdoc} replacement. Thanks @asm89 for point…
…ing out.
df367a1
Guilherme Blanco Fixed bug with localized exporting uner XLIFF. b57dce1
Guilherme Blanco Fixed original file name exporter in XLIFF exporter. 7f7d040
Catalin Costache fix default locale parameter 56df1b1
Catalin Costache update the docs e2c32b3
Catalin Costache add the yaml exporter to the list of available services 4a1f4d4
Catalin Costache fix yaml importer typo 4a54302
Catalin Costache add template checks for null values 9e58eac
Catalin Costache refactor the importer to allow multi file type imports
delegate the import to an ImportInterface implementation that supports
the file type
f6e5d66
Catalin Costache add the yaml importer 70e4b92
Alexander

Any news on this?

Guilherme Blanco

I have a pending patch that removes the necessity of importers configuration.
It also already update docs.
So as soon as possible (and the author updates PR with suggested changes), I'll merge and it will become ok to ServerGrove to merge.

and others added some commits February 28, 2012
Catalin Costache move the file extension check in the abstract importer, change xlf to…
… xliff
be24327
Guilherme Blanco Merge pull request #1 from catacgc/master
Fix some configuration bugs and add some info about the configuration in README.md
4884b1b
Guilherme Blanco

Hi @pgodel !

I merged a new change @catacgc submitted.
Now it's much reach since you don't require to define the importer and also YAML exporter is running smoothly.

Any estimates when you're going to merge his?

Nikola Petkanski

Last comment on this one has been a month ago. Any updates since then?

Nikola Petkanski
dinamic commented May 09, 2012

@pgodel ping

Pablo Godel
Collaborator
pgodel commented May 09, 2012

We have not had time to merge the PR yet, sorry! We have been swamped with work. If there is anybody willing to implement mongodb in the PR it would be great!

Gordon Franke

ping. warm up this topic again.

Gordon Franke

this ticket fix #5 and #1

Damien Alexandre

Great PR but:

  • Documentation is not up-to-date, refer to Mongo, Orm, but do not expose the right one;
  • Why the f*** Pablo's name is removed from the composer file? authors accept an array;
  • Classes declared as services in Resources/config/services.xml should be parameters.

Beside that, ping @servergrove - this definitly deserve a merge :+1:

Pablo Godel
Collaborator

We are still swamped with work. Hopefully will be able to dedicate some time soon, sorry.

Michaël Perrin

:+1: Nice PR

and others added some commits April 10, 2013
Alessandro Tagliapietra Updated bootstrap and jquery assets url
Bootstrap urls were giving 404 and I've updated them with netdna hosted version and also the new jquery version
2cd58e8
Anthon Pang Merge pull request #10 from alex88/patch-1
Updated bootstrap and jquery assets url

Note: the reason the bootstrap URLs are 404'ing is due to https://github.com/blog/1452-new-github-pages-domain-github-io
8415a67
Gordon Franke

ping

ServerGrove
Owner
Pablo Garrido

You gotta check if there isn't already an existing one before approving an entry modification. =)

Guilherme Blanco

Don't think this one is possible anymore. Google Translation API is now paid only IIRC.

So, it's technically possible. It just wouldn't be free.

Guilherme Blanco

I think you can do this already using alternate Symfony tools. Needs checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 84 unique commits by 16 authors.

Feb 07, 2012
Guilherme Blanco Initial efforts around conversion from MongoDB specific to Storage ag…
…nostic (but implementing ORM as default).
146c1f7
Guilherme Blanco Added missing field to Entry. 558e3e8
Guilherme Blanco Refactored services initialization for consistency with Symfony stand…
…ards.
6a994aa
Juti Noppornpitak Refactored the code. (This commit will break YML import.) daa3dc0
Juti Noppornpitak Laid out the code to support Xliff files with ORM. 3dc3fd9
Guilherme Blanco Several fixes to entities and also initial efforts on controller. 13f3669
Juti Noppornpitak Refactored the code ready for integrating with ORM. 08e052c
Guilherme Blanco Merge branch 'master' of github.com:instaclick/TranslationEditorBundle ff52dea
Guilherme Blanco More work around ImportCommand. 2231ef2
Juti Noppornpitak Added createLocale and updated the variable referencing AppKernel. 07d1827
Guilherme Blanco Finished import command. Still need to test if UTF-8 chars are import…
…ed correctly.
f331db8
Feb 08, 2012
Guilherme Blanco Refactored frontend. Most actions are working (except the new transla…
…tion).
af5f151
Juti Noppornpitak Refactored the code from ImportCommand to Base; finished the coding t…
…o analyze, classify the translation and rendered into a string in ExportCommand. Please note that ExportCommand in this commit cannot write a file.
c07430c
Juti Noppornpitak Refactored the XLIFF file handler from the export command and make th…
…e file handler as a service.
82a63d0
Feb 13, 2012
Guilherme Blanco Finished changes in Import and Export Commands. Now they are complete…
…ly isolated.
ef2d950
Guilherme Blanco Optimized ORMStorage and also added missing methods on StorageInterfa…
…ce. Also, moved ObjectManager compatible code to AbstractStorage.
959a36d
Guilherme Blanco Made new entry works. 269777c
Guilherme Blanco Improved reusabiity of Importers. Added YamlImporter. 73cbf3b
Guilherme Blanco Committed missing file 483a79d
Feb 15, 2012
Guilherme Blanco Added YAML Exporter. 2257daa
Guilherme Blanco Added support to create and drop locales dynamically. fd8dfe2
Guilherme Blanco Turned domain into a drop down list. 7ba43b2
Guilherme Blanco {{@inheritdoc}} => {@inheritdoc} replacement. Thanks @asm89 for point…
…ing out.
df367a1
Feb 27, 2012
Guilherme Blanco Fixed bug with localized exporting uner XLIFF. b57dce1
Guilherme Blanco Fixed original file name exporter in XLIFF exporter. 7f7d040
Feb 28, 2012
Catalin Costache fix default locale parameter 56df1b1
Catalin Costache update the docs e2c32b3
Catalin Costache add the yaml exporter to the list of available services 4a1f4d4
Catalin Costache fix yaml importer typo 4a54302
Catalin Costache add template checks for null values 9e58eac
Catalin Costache refactor the importer to allow multi file type imports
delegate the import to an ImportInterface implementation that supports
the file type
f6e5d66
Catalin Costache add the yaml importer 70e4b92
Catalin Costache move the file extension check in the abstract importer, change xlf to…
… xliff
be24327
Mar 05, 2012
Guilherme Blanco Merge pull request #1 from catacgc/master
Fix some configuration bugs and add some info about the configuration in README.md
4884b1b
Mar 13, 2012
Guilherme Blanco Update Controller/EditorController.php a83d549
May 17, 2012
Nikola Petkanski ~ using text type for the translation faf8dd0
Guilherme Blanco Merge pull request #2 from dinamic/master
Translation type varchar -> text
a6c49fb
Guilherme Blanco Updated composer.json. bef899b
May 19, 2012
Nikola Petkanski ~ display 'MISSING' if a translation does not exist or is empty 1a5f370
Guilherme Blanco Merge pull request #3 from dinamic/master
bugfix: unable to set translation
77a2284
May 24, 2012
cajoy Added the support for Symfony 2.1 by making the code automatically de…
…termine the extension based on the version of Symfony kernel.
963f5c3
Jun 15, 2012
Guilherme Blanco Update master 79c063f
Jun 22, 2012
Juti Noppornpitak Change the interface to allow "getFileExtension" to return either a s…
…tring or an array.
835bae6
Juti Noppornpitak Added the support for legacy extensions (e.g., XLIFF and XLF extensions) 30c675a
Juti Noppornpitak added debug code d8d28f1
Juti Noppornpitak Added support for Symfony 2.1 and 2.0 (BC). 2a13c0e
Juti Noppornpitak removed the debugging code, properly support 2.0 and 2.1 and took out…
… the array support.
a7ab7b8
Juti Noppornpitak Added the missing module. b1c3acd
Aug 03, 2012
Guilherme Blanco Removed dependency of ORM EntityRepository, allowing custom implement…
…ations of EntityRepository to not require a non-interfaced Common Persistence method createQueryBuilder.
d4f50cb
Aug 14, 2012
Gordon Franke update code for bootstrap 2 b578b83
Aug 16, 2012
Gordon Franke remove inline js 22fdd2a
Gordon Franke replace Translation implementation with symfony translator service 05b0774
Guilherme Blanco Merge pull request #5 from gimler/bootstrap2
Bootstrap2
03e4f35
Guilherme Blanco Merge pull request #4 from gimler/translator
Use symfony translation service
3d95c96
Aug 22, 2012
Fixing addTranslationAction() 8c2a45f
Sep 18, 2012
Charles-Eric Gorron fixed typo 90f5691
Anthon Pang Merge pull request #6 from ch3ric/patch-1
fixed typo
f575fb0
Sep 27, 2012
Anthon Pang update composer.json f774ac2
Nov 28, 2012
Charles-Eric Gorron removed useless conf (exporter) 0a2257d
Charles-Eric Gorron removed useless conf (exporter) 15c74a4
Charles-Eric Gorron removed useless conf (exporter) 412025c
Charles-Eric Gorron The catalogue domain corresponds to the fileName b7d8843
Guilherme Blanco Merge pull request #7 from ch3ric/master
Removed useless conf and fixed filename during export
34d301e
Mar 06, 2013
Yuan Xie Update ImportCommand.php a5fcb20
Yuan Xie Update AbstractStorage.php b60711b
Yuan Xie Update StorageInterface.php 0abfd28
Anthon Pang Merge pull request #8 from yxie/master
This patch will reduce the TranslationImport command's running time from 45+ mins to 1.5 mins.
8238c5f
Mar 07, 2013
Anthon Pang Update composer.json 284abb3
Mar 12, 2013
1) Fixing issue that entity aren't persisted; 2) further optimize per…
…formance;
5559097
3) Fixing the JavaScript that wrong locale is deleted by the delete b…
…uttons
8946e1e
Guilherme Blanco Merge pull request #9 from yxie/master
Fixing various bugs during use of the bundle
af863de
Apr 10, 2013
Alessandro Tagliapietra Updated bootstrap and jquery assets url
Bootstrap urls were giving 404 and I've updated them with netdna hosted version and also the new jquery version
2cd58e8
Anthon Pang Merge pull request #10 from alex88/patch-1
Updated bootstrap and jquery assets url

Note: the reason the bootstrap URLs are 404'ing is due to https://github.com/blog/1452-new-github-pages-domain-github-io
8415a67
Jul 17, 2013
Clément Gautier Fixed filer to accept anything before the first dot 85ba131
Nov 19, 2013
Guilherme Blanco Merge pull request #12 from ETSGlobal/fix-file-finder
Fixed filer to accept anything before the first dot
40d2181
Guilherme Blanco Update composer.json f62a2e1
Dec 17, 2013
Pablo Garrido Update ImportCommand.php
Add support to import files like messages.es_ES.yml
921de0f
Pablo Garrido Avoid error on empty value 8f95db6
Guilherme Blanco Merge pull request #13 from pgarrido/patch-1
Update ImportCommand.php
de9e535
Pablo Garrido Update template to bootstrap 3.0 Step 1 0ca4eb2
Dec 19, 2013
Pablo Garrido Update template to bootstrap 3.0 and add search capability 2b47c8d
Pablo Garrido Fix function names b926e6a
Guilherme Blanco Update README.md
Modifications for #14
53903dc
Guilherme Blanco Merge pull request #14 from pgarrido/master
Update to bootstrap 3 and add search capability
4137409
Something went wrong with that request. Please try again.