Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Integrate with "Serverless invoke local" and change the "webpack invoke" command #151
This is a Feature Proposal
Serverless offers a fully working
There is no need to have a separate
It would be better to integrate seamlessly with
To make it completely seamless, the
This solution would also make the invocation provider independent as Serverless fully takes care of that already.
changed the title
Integrate with "Serverless invoke local" and remove the "webpack invoke" command
Jul 11, 2017
During the implementation I saw that it could make sense to couple the
@benjaminwood @hassankhan The basic implementation is finished (support of "serverless invoke local"), i.e. sls invoke local should now work with the plugin. I did a few tests with my test project. Could you also verify that it works with this PR (#153)?
I will finish it over the weekend and remove the now obsolete code, adapt the docs and write unit tests.
This is great, thanks @HyperBrain! It does work for me, though I did run into one snag.
When using the invoke local command with the --path (-p) flag, relative file paths will not be found because serverless will end up looking in the build directory (.webpack) later on.
I took a stab at fixing this and I'm happy to PR it if I'm headed down the right path: benjaminwood@37086ed
Couldn't think of a good name for the function. Also, I'm not sure that this should go in the utils file. Happy to make revisions! Let me know what you think.
Hey @benjaminwood . Thanks a lot, good catch
So just open a PR
... and I'm really glad to hear that my changes work (with exception of the path issue)