New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serverless-offline exec is broken #154

Closed
jgilbert01 opened this Issue Jul 14, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@jgilbert01
Copy link
Contributor

jgilbert01 commented Jul 14, 2017

This is a Bug Report

Description

Serverless-offline has a nifty feature called scoped execution that can be used for automated integration testing.

This exec feature is currently not working with serverless-webpack because the tests get executed before webpack watch has a chance to compile the source.

Proposed Solution

The proposed solution is to execute compile after validate and before watch. This will force a compile when serverless-offline is started but before the tests are executed and still support watch for non automated scenarios that do not have the race condition.

Additional Data

  • Serverless-Webpack Version 2.0.0:
  • Webpack version 3.0.0:
  • Serverless Framework Version 1.17.0:
  • Serverless-Offline Version 3.15.0:

@HyperBrain HyperBrain added the bug label Jul 15, 2017

@HyperBrain HyperBrain added this to the 2.1.0 milestone Jul 17, 2017

@jgilbert-hobsons

This comment has been minimized.

Copy link

jgilbert-hobsons commented Jul 27, 2017

thx for accepting this merge request. is there any plan to publish a new version to npm?

@HyperBrain

This comment has been minimized.

Copy link
Member

HyperBrain commented Jul 27, 2017

Most likely today ;-)

@jgilbert-hobsons

This comment has been minimized.

Copy link

jgilbert-hobsons commented Jul 27, 2017

Excellent!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment