New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the standard Serverless servicePath in the plugin #173

Closed
HyperBrain opened this Issue Jul 28, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@HyperBrain
Copy link
Member

HyperBrain commented Jul 28, 2017

This is a Feature Proposal

Description

Until now the plugin overwrites the servicePath property in Serverless during its lifecycle and
sets it back in the cleanup lifecycle event. This makes the whole system very fragile and dependent on
the consistent use of the property in Serverless as well as all other plugins. In the extreme, we can
throw the dice, if the next Serverless version will lead to problems or not.

This behavior should be changed and the plugin should use the given servicePath as plugins are
expected to do.

I think the change is not trivial, because there has to be a reason, why this approach has been taken.
We should analyze every single step in the plugin and check if there are any issues that can arise from
changing it to a stable use.

After the implementation has been done, it should be tested properly and ripen in master for a while.

@HyperBrain HyperBrain self-assigned this Jul 30, 2017

@HyperBrain HyperBrain added this to the 3.0.0 milestone Aug 4, 2017

This was referenced Aug 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment