New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set webpack target property to "node" in case it is missing in the config #276

Closed
HyperBrain opened this Issue Nov 15, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@HyperBrain
Copy link
Member

HyperBrain commented Nov 15, 2017

This is a Feature Proposal

Description

It turned out in #274 , that, when the target: "node" property is missing in the webpack configuration, the compiles mostly work, but are missing the environment variables.
For the user this is not obvious, but can be checked by the plugin easily. It would be a great UX improvement, if the plugin could warn about the missing setting and set it to "node" automatically if absent.

Similar or dependent issue(s):

Additional Data

  • Serverless-Webpack Version you're using:
  • Webpack version you're using:
  • Serverless Framework Version you're using:
  • Operating System:
  • ***Stack Trace (if available)***:
@HyperBrain

This comment has been minimized.

Copy link
Member Author

HyperBrain commented Nov 21, 2017

Released with 4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment