New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke without building #341

Closed
sime opened this Issue Mar 8, 2018 · 7 comments

Comments

Projects
None yet
2 participants
@sime
Copy link

sime commented Mar 8, 2018

This is a Feature Proposal

Description

  • What is the use case that should be solved. The more detail you describe this in the easier it is to understand for us.
    We test our functions by running sls invoke local --function blah in CI. It is one of our slowest parts of pipeline. It would be ideal if it could be built once and flagged not to build again.
sls webpack
sls invoke local --function blah1 --noBuild
sls invoke local --function blah2 --noBuild

Similar or dependent issue(s):

  • n/a

Additional Data

  • Serverless-Webpack Version you're using: 4.1.0
  • Webpack version you're using: 3.8.1
  • Serverless Framework Version you're using: 1.25
  • Operating System: OS X/Linux
@sime

This comment has been minimized.

Copy link
Author

sime commented Mar 8, 2018

@HyperBrain

This comment has been minimized.

Copy link
Member

HyperBrain commented Mar 8, 2018

Hi @sime . I agree, especially in a CI context the pattern is 1 * build, n * invoke. So, a single compile would make sense and a switch to disable building explicitly on all subsequent invokes.

This is related to #288 and might solve this too.

@HyperBrain

This comment has been minimized.

Copy link
Member

HyperBrain commented Mar 13, 2018

PR available for testing. Use "serverless-webpack": "github:serverless-heaven/serverless-webpack#skip-build-with-invoke-local"

@HyperBrain HyperBrain added this to the 5.1.0 milestone Mar 13, 2018

@HyperBrain

This comment has been minimized.

Copy link
Member

HyperBrain commented Mar 14, 2018

@sime Do you have any chance to test the PR?

@sime

This comment has been minimized.

Copy link
Author

sime commented Mar 14, 2018

@HyperBrain We run our CI on Travis and just tested it. CI time is now 2 minutes faster!

@HyperBrain

This comment has been minimized.

Copy link
Member

HyperBrain commented Mar 14, 2018

@sime Sounds good. I'll merge the PR now (and delete the branch). Please change to master to keep your builds working in case you continue to use it before the release.

@HyperBrain

This comment has been minimized.

Copy link
Member

HyperBrain commented Mar 14, 2018

Released with 5.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment