New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn resolutions is not respected #379

Closed
otbe opened this Issue Apr 29, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@otbe
Copy link

otbe commented Apr 29, 2018

This is a Bug Report

Description

I use yarn as my packager for serverless-webpack. In my package.json I have defined resolutions to force yarn to use a specific version of a dependency. This works quite well in my project, but it won't get applied when I run sls webpack.

In my output folder of serverless-webpack (.webpack/) is a package.json without the resolutions field. If I run yarn list <package> I get multiple entries of this dependency where I expected exactly one. If I run yarn install --frozen-lockfile I get Lockfile has incorrect entry for "graphql@^0.11.7". Ignoring it. which leads to this missbehavior.

This is my serverless-webpack related config:

custom: 
  webpack:
    includeModules: true
    packager: yarn

If I add resolutions to package.json it works as it should.

This may be a bug within yarn itself, because I expect when using --frozen-lockfile it should take whats in the lockfile.

Versions:
serverless-webpack@5.1.3
webpack@4.6.0
serverless@1.26.1
yarn@1.6.0

Thanks!

@HyperBrain

This comment has been minimized.

Copy link
Member

HyperBrain commented Apr 30, 2018

Hi @otbe ,
thanks for raising the issue. I think this is a bug in serverless-webpack. It should be fixed to use and copy the resolutions definition from your original package.json to the created ones.
As you confirmed that adding the section solves the problem, this should be the right way to go.

@HyperBrain HyperBrain added the bug label Apr 30, 2018

@HyperBrain HyperBrain added this to the 5.1.4 milestone Apr 30, 2018

@otbe

This comment has been minimized.

Copy link
Author

otbe commented May 2, 2018

Thank you very much!
Waiting for 5.1.4 👍

@HyperBrain

This comment has been minimized.

Copy link
Member

HyperBrain commented May 4, 2018

Released with 5.1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment