Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
aws-sdk: warning on deployment #393
This is a Bug Report
Updated webpack serverless and now get warning when deploying
Similar or dependent issue(s):
Hi @shavo007 , thanks for the report
This warning is expected, because I improved the dependency detection to be able to find common issues where dependencies are set in devDependencies instead of dependencies (I treated this missing behavior as a bug, because it could lead to defunctional deployments). These issues are very hard to track down, because previously they only led to crashes when deployed.
To get rid of the warning and have a correct project setup you should set the aws-sdk as forcefully excluded. This explicitly states that it is not deployed intentionally (as the serverless.yml is declarative, this is then more correct than silently excluding it). So, just add:
in your serverless.yml and the warning will be gone and it expresses, what is happening and what is intended.
hi @HyperBrain thanks for the response.
Issue is that it is correctly defined as a dev dependency (aws lambda includes aws-sdk in container).
That is why i do not have it as a dependency.
When i see a warning in my CI server i assume there is a problem.
What you think?
@shavo007 As I wrote, there is no problem and you defined it correctly in devDependencies
The only thing you should do is, to define the
referenced this issue
May 15, 2018
tbh @HyperBrain im just not a big fan of this change!
i shoudnt have to declaratively exclude aws-sdk to resolve the warning. When in fact I am doing the right thing and defining it as a dev dependency.
Why have this warning in the first place? Why not have a whitelist and exclude aws-sdk?
@shavo007 What we could do is, to restrict the warning to only show up with