New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples minor improvements #179

Merged
merged 1 commit into from Aug 3, 2017

Conversation

Projects
None yet
2 participants
@franciscocpg
Copy link
Member

franciscocpg commented Aug 3, 2017

What did you implement:

Related to #137

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors (not yet implemented)
  • Make sure code coverage hasn't dropped (not yet implemented)
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

- Upgrading node runtime
- Using slsw.lib.entries with in typescript example
@HyperBrain

This comment has been minimized.

Copy link
Member

HyperBrain commented Aug 3, 2017

Looks good

@HyperBrain HyperBrain merged commit cf51110 into serverless-heaven:master Aug 3, 2017

@franciscocpg franciscocpg deleted the franciscocpg:examples-minor-improvements branch Aug 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment