New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log errors in webpack config explicitly. #234

Merged
merged 2 commits into from Sep 21, 2017

Conversation

Projects
None yet
1 participant
@HyperBrain
Copy link
Member

HyperBrain commented Sep 21, 2017

What did you implement:

This PR adds an extra log line if the webpack config file could not be loaded.
This makes the reason for errors in the configuration more clear than just printing the
actual exception without context.

How did you implement it:

Added a try/catch around the require() of the configuration file.

How can we verify it:

Implement a syntax error in your webpack config. Any try to package or deploy should mention
to the configuration file now before printing the error message or stacktrace.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@HyperBrain HyperBrain added this to the 3.1.0 milestone Sep 21, 2017

@HyperBrain HyperBrain referenced this pull request Sep 21, 2017

Closed

Unexpected Token ... #233

@HyperBrain HyperBrain merged commit ff5ef0c into master Sep 21, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.5%) to 90.323%
Details

@HyperBrain HyperBrain deleted the improve-error-config-load branch Sep 21, 2017

@HyperBrain

This comment has been minimized.

Copy link
Member Author

HyperBrain commented Sep 22, 2017

Released with 3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment