New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed libraryTarget link in webpack docs #321

Merged
merged 1 commit into from Feb 6, 2018

Conversation

Projects
None yet
2 participants
@pcowgill
Copy link
Contributor

pcowgill commented Feb 6, 2018

What did you implement:

Fixed libraryTarget link in webpack docs

How did you implement it:

Just a README change

How can we verify it:

Look at the README and verify the new link works better in your browser

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@HyperBrain

This comment has been minimized.

Copy link
Member

HyperBrain commented Feb 6, 2018

@pcowgill Thanks 😄

@HyperBrain HyperBrain added this to the 4.3.0 milestone Feb 6, 2018

@HyperBrain HyperBrain merged commit af1100b into serverless-heaven:master Feb 6, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 96.774%
Details

@pcowgill pcowgill deleted the pcowgill:feature/library-target-link branch Feb 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment