Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Use chunk.forEachModules instead of deprecated chunk.modules #328
What did you implement:
Webpack 4 removes the deprecated chunk.modules property. This uses the forEachModule instead. See https://github.com/webpack/webpack/blob/webpack-3/lib/Chunk.js#L473.
How did you implement it:
Trivial, most changes were to update tests.
How can we verify it:
Is this ready for review?: YES
Hi @janicduplessis, thanks for the PR. It indeed makes sense to switch to the no-deprecated chunk module enumerator.
Regarding webpack 2 support, I think there are a lot of serverless projects out there that make use of it. Either we schedule this change for
However, I'd prefer a new major version, because as the old functionality is deprecated, it is much cleaner to continue with only the correct implementation and drop webpack 2 support.