Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor configuration #336
What did you implement:
This PR consolidates all webpack plugin configuration settings into the new
There is one breaking change with the configuration: If you have chosen to embed the webpack configuration into the serverless.yml (previously by defining
The new configuration object has the following layout. If a property is omitted, it will default to the shown values:
custom: webpack: webpackConfig: 'webpack.config.js' webpackIncludeModules: false packager: 'npm' packExternalModulesMaxBuffer: 200 * 1024 }
All settings have just been moved, but semantically are exactly as before.
However, the old configuration keys continue to work, but will lead to a warning message to let people know that there is a better alternative for configuration now.
How did you implement it:
Use a new class to keep the configuration centralized. The class is initialized with the serverless custom object and will populate the settings from there (using the old semantics as fallback) and it will set reasonable defaults for anything that has not been set.
How can we verify it:
(1) Use an existing project as is. It should build as usual but show a warning.
Is this ready for review?: YES