New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the out-dated documentation #354

Merged
merged 1 commit into from Mar 21, 2018

Conversation

Projects
None yet
2 participants
@posquit0
Copy link
Contributor

posquit0 commented Mar 21, 2018

What did you implement:

serverless-webpack already support packager option in serverless.yml file. So, the comment in README.md should be updated.

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@HyperBrain

This comment has been minimized.

Copy link
Member

HyperBrain commented Mar 21, 2018

@posquit0 Nice catch 👍 . I missed that one.

@HyperBrain HyperBrain added this to the 5.1.1 milestone Mar 21, 2018

@HyperBrain HyperBrain merged commit 120038f into serverless-heaven:master Mar 21, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@posquit0 posquit0 deleted the posquit0:patch-1 branch Mar 21, 2018

@renovate renovate bot referenced this pull request Nov 9, 2018

Open

chore(deps): serverless-webpack #17

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment