New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Webpack 4 example #355

Merged
merged 1 commit into from Mar 22, 2018

Conversation

Projects
None yet
1 participant
@HyperBrain
Copy link
Member

HyperBrain commented Mar 21, 2018

What did you implement:

Closes #XXXXX

Add example using Webpack 4. The example demonstrates the new settings in the webpack config as well as the new sls-webpack configuration layout in serverless.yml

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@HyperBrain HyperBrain added this to the 5.1.1 milestone Mar 22, 2018

@HyperBrain HyperBrain merged commit ad24e5c into master Mar 22, 2018

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 91.575%
Details

@HyperBrain HyperBrain deleted the webpack-4-example branch Mar 22, 2018

@renovate renovate bot referenced this pull request Nov 9, 2018

Open

chore(deps): serverless-webpack #17

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment