New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vscode debug #365

Merged
merged 5 commits into from Apr 6, 2018

Conversation

Projects
None yet
2 participants
@franciscocpg
Copy link
Member

franciscocpg commented Apr 6, 2018

What did you implement:

Closes #364

How did you implement it:

Adding a .vscode/launch.json to provide debug feature using vscode.

How can we verify it:

  • Checkout this PR branc
  • go to babel-webpack-4 example folder
  • Run npm install
  • Try debugging it in vscode using all the provided configurations.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@@ -2,6 +2,7 @@ service: babel-webpack-4-example

# Add the serverless-webpack plugin
plugins:
- serverless-offline

This comment has been minimized.

@HyperBrain

HyperBrain Apr 6, 2018

Member

I think this order should be reversed, shouldn't it? The sls-webpack hooks should precede the offline hooks internally.

This comment has been minimized.

@franciscocpg

franciscocpg Apr 6, 2018

Author Member

It worked for me this way, but I realized that at README we state to use serverless-offline after serverless-webpack so I'm going to change it.

@HyperBrain
Copy link
Member

HyperBrain left a comment

Looks good. Thanks for the good work as always 👍

@HyperBrain HyperBrain merged commit 5cf2479 into serverless-heaven:master Apr 6, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.557%
Details

@franciscocpg franciscocpg deleted the franciscocpg:vscode-debug branch Apr 6, 2018

@renovate renovate bot referenced this pull request Nov 9, 2018

Open

chore(deps): serverless-webpack #17

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment