From 559e5b7154c7e14ada50716e8119a2ca57094e7d Mon Sep 17 00:00:00 2001 From: Pradyumna Newalkar Date: Tue, 8 Sep 2020 13:33:29 +0530 Subject: [PATCH] fix bucketname extraction from origin url --- .../aws-cloudfront/lib/getBucketNameFromUrl.js | 4 ++++ .../aws-cloudfront/lib/getOriginConfig.js | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 packages/serverless-components/aws-cloudfront/lib/getBucketNameFromUrl.js diff --git a/packages/serverless-components/aws-cloudfront/lib/getBucketNameFromUrl.js b/packages/serverless-components/aws-cloudfront/lib/getBucketNameFromUrl.js new file mode 100644 index 0000000000..8469a4ad8e --- /dev/null +++ b/packages/serverless-components/aws-cloudfront/lib/getBucketNameFromUrl.js @@ -0,0 +1,4 @@ +module.exports = (hostname) => { + const domains = hostname.split("."); + return domains.slice(0, domains.indexOf("s3")).join("."); +}; diff --git a/packages/serverless-components/aws-cloudfront/lib/getOriginConfig.js b/packages/serverless-components/aws-cloudfront/lib/getOriginConfig.js index 923030a084..b12e31fa1b 100644 --- a/packages/serverless-components/aws-cloudfront/lib/getOriginConfig.js +++ b/packages/serverless-components/aws-cloudfront/lib/getOriginConfig.js @@ -1,3 +1,4 @@ +const getBucketNameFromUrl = require("./getBucketNameFromUrl"); const url = require("url"); module.exports = (origin, { originAccessIdentityId = "" }) => { @@ -16,7 +17,7 @@ module.exports = (origin, { originAccessIdentityId = "" }) => { }; if (originUrl.includes("s3")) { - const bucketName = hostname.split(".")[0]; + const bucketName = getBucketNameFromUrl(hostname); originConfig.Id = bucketName; originConfig.DomainName = hostname; originConfig.S3OriginConfig = {