Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Images to img Directory #802

Merged
merged 3 commits into from Nov 17, 2020
Merged

Move Images to img Directory #802

merged 3 commits into from Nov 17, 2020

Conversation

rosborne132
Copy link
Contributor

This PR includes the following:

  • Cleans up the root directory by moving the images to the img directory.
  • Fixes minor typo in README.md

@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #802 (dc5ffd7) into master (29719f5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #802   +/-   ##
=======================================
  Coverage   80.23%   80.23%           
=======================================
  Files          57       57           
  Lines        1862     1862           
  Branches      410      410           
=======================================
  Hits         1494     1494           
  Misses        310      310           
  Partials       58       58           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29719f5...dc5ffd7. Read the comment docs.

README.md Outdated
@@ -381,7 +381,7 @@ myNextApplication:
apiLambda: "nodejs10.x"
```

Similarly, the timeout by default is 10 seconds. To customise you can:
Similarly, the timeout by default is 10 seconds. To customize you can:
Copy link
Collaborator

@dphang dphang Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! This is actually not a typo, as the original author of this package @danielcondemarin is based in the UK and these are the British spellings 😛.

I'm fine with reorganizing the images though, since there are a lot of files now in the repository root.

README.md Outdated
@@ -421,7 +421,7 @@ The third is associated to a lambda function which is responsible for handling t

1. Server side rendered page. Any page that defines `getInitialProps` method will be rendered at this level and the response is returned immediately to the user.

2. Statically optimised page. Requests to pages that were pre-compiled by next to HTML are forwarded to S3.
2. Statically optimized page. Requests to pages that were pre-compiled by next to HTML are forwarded to S3.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here for optimised

@rosborne132
Copy link
Contributor Author

@dphang Thanks for the feedback. I've removed my typo fixes. :)

@dphang
Copy link
Collaborator

dphang commented Nov 17, 2020

@dphang Thanks for the feedback. I've removed my typo fixes. :)

Thanks! I will approve and merge it after the CI passes.

@dphang dphang merged commit 8d384cf into serverless-nextjs:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants