Generating random variable names for intrinsic functions breaks Serverless caching #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@FilipPyrek thanks for the PR, is this ready for review? |
Contributor
Author
|
@theburningmonk not yet. During refactoring I noticed that also compileNotifications.js is using But please check the changed files and let me know if you see any problem with my implementation. |
Collaborator
|
@FilipPyrek no probs, thank you 👍 |
Contributor
Author
|
Ready for review @theburningmonk 👍 |
Collaborator
|
@FilipPyrek sorry, got distracted with other things and didn't get around to reviewing until now |
Collaborator
|
🎉 This PR is included in version 2.17.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 similar comment
Collaborator
|
🎉 This PR is included in version 2.17.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ss-betseqnzr
pushed a commit
to BetSEQNZR/serverless-step-functions
that referenced
this pull request
Sep 8, 2023
…aster Generating random variable names for intrinsic functions breaks Serverless caching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #299