Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add AWS SES community example #704

Merged
merged 2 commits into from
Jun 5, 2022

Conversation

domdomegg
Copy link

Currently, I don't think there's an example in the repo for sending emails with SES. Additionally, the community examples all seem to use the AWS SES V1 API, whereas AWS is pushing users to use the V2 API. They also don't have offline support.

This PR adds a well documented example to the repo that explains how to send email with the AWS SES V2 SDK with offline support.

@pgrzesik
Copy link
Contributor

Hey @domdomegg - thanks a lot for your submission. Could you please submit it as a community example? We're in the process of limiting the number of official examples (a lot of them are quite outdated) and we'd rather accept new ones as community submissions at this point.

cc @mnapoli

@domdomegg domdomegg force-pushed the domdomegg/ses-sending-example branch from 0ab241b to e52a942 Compare June 5, 2022 01:53
@domdomegg
Copy link
Author

Hi @pgrzesik, I've resubmitted this as a community example :)

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @domdomegg 🙇

@pgrzesik pgrzesik changed the title Add AWS SES sending example feat: Add AWS SES community example Jun 5, 2022
@pgrzesik pgrzesik merged commit d75ac50 into serverless:v3 Jun 5, 2022
@domdomegg domdomegg deleted the domdomegg/ses-sending-example branch June 5, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants