From d5a434af833ce91be3e33eaccd8ca7d871b5a79c Mon Sep 17 00:00:00 2001 From: Jose Luis Date: Fri, 1 Mar 2019 10:56:51 +0100 Subject: [PATCH 1/6] Update layer.js Fix the issue -> TypeError: Cannot set property 'pythonRequirements' of undefined at ServerlessPythonRequirements.createLayers (/Users/alcaljos/Projects/GMR/gmr-imu-video-synch/node_modules/serverless-python-requirements/lib/layer.js:28:56) From previous event: Since the layers object seems to not be initialized. --- lib/layer.js | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/layer.js b/lib/layer.js index 06c70871..dac7aee3 100644 --- a/lib/layer.js +++ b/lib/layer.js @@ -25,6 +25,7 @@ function zipRequirements() { * @return {Promise} empty promise */ function createLayers() { + this.serverless.service.layers['pythonRequirements'] = {} this.serverless.service.layers['pythonRequirements'] = Object.assign( { artifact: path.join('.serverless', 'pythonRequirements.zip'), From 113916bc83f516ebef45c5e0fedb83e97a952950 Mon Sep 17 00:00:00 2001 From: Jose Luis Date: Sun, 3 Mar 2019 14:11:34 +0100 Subject: [PATCH 2/6] Update layer.js Check if it's null or undefifned --- lib/layer.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/layer.js b/lib/layer.js index dac7aee3..8ac0b413 100644 --- a/lib/layer.js +++ b/lib/layer.js @@ -25,7 +25,9 @@ function zipRequirements() { * @return {Promise} empty promise */ function createLayers() { - this.serverless.service.layers['pythonRequirements'] = {} + if(!this.serverless.service.layers['pythonRequirements']){ + this.serverless.service.layers['pythonRequirements'] = {} + } this.serverless.service.layers['pythonRequirements'] = Object.assign( { artifact: path.join('.serverless', 'pythonRequirements.zip'), From f3831d19954791567227824fe37ce486eb7e83a8 Mon Sep 17 00:00:00 2001 From: Daniel Schep Date: Mon, 15 Apr 2019 14:11:34 -0400 Subject: [PATCH 3/6] Fix layers being undefined --- lib/layer.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/layer.js b/lib/layer.js index 8ac0b413..3376d1d1 100644 --- a/lib/layer.js +++ b/lib/layer.js @@ -25,8 +25,8 @@ function zipRequirements() { * @return {Promise} empty promise */ function createLayers() { - if(!this.serverless.service.layers['pythonRequirements']){ - this.serverless.service.layers['pythonRequirements'] = {} + if(!this.serverless.service.layers){ + this.serverless.service.layers = {} } this.serverless.service.layers['pythonRequirements'] = Object.assign( { From 82fa76d95a333ba55c506ba66b3f45ad4b220231 Mon Sep 17 00:00:00 2001 From: Daniel Schep Date: Mon, 15 Apr 2019 14:31:37 -0400 Subject: [PATCH 4/6] lint --- lib/layer.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/layer.js b/lib/layer.js index 3376d1d1..ccc632d0 100644 --- a/lib/layer.js +++ b/lib/layer.js @@ -25,7 +25,7 @@ function zipRequirements() { * @return {Promise} empty promise */ function createLayers() { - if(!this.serverless.service.layers){ + if (!this.serverless.service.layers){ this.serverless.service.layers = {} } this.serverless.service.layers['pythonRequirements'] = Object.assign( From 3fee07bf86789b801b3ec12742c8a9f0f4b8d930 Mon Sep 17 00:00:00 2001 From: Daniel Schep Date: Mon, 15 Apr 2019 14:40:03 -0400 Subject: [PATCH 5/6] morelint --- lib/layer.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/layer.js b/lib/layer.js index ccc632d0..54c904db 100644 --- a/lib/layer.js +++ b/lib/layer.js @@ -25,7 +25,7 @@ function zipRequirements() { * @return {Promise} empty promise */ function createLayers() { - if (!this.serverless.service.layers){ + if (!this.serverless.service.layers) { this.serverless.service.layers = {} } this.serverless.service.layers['pythonRequirements'] = Object.assign( From cce5227f212281b3c44af71a5de43ba62e14997c Mon Sep 17 00:00:00 2001 From: Daniel Schep Date: Tue, 16 Apr 2019 11:35:05 -0400 Subject: [PATCH 6/6] really fix lint --- lib/layer.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/layer.js b/lib/layer.js index 54c904db..f512ded1 100644 --- a/lib/layer.js +++ b/lib/layer.js @@ -26,7 +26,7 @@ function zipRequirements() { */ function createLayers() { if (!this.serverless.service.layers) { - this.serverless.service.layers = {} + this.serverless.service.layers = {}; } this.serverless.service.layers['pythonRequirements'] = Object.assign( {