This repository was archived by the owner on Oct 24, 2025. It is now read-only.
Preserve binary file permissions in zip #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bspink
force-pushed
the
fix-zip-permissions
branch
from
82a0529 to
6d1308e
Compare
Contributor
|
Hmm, do tests pass for you locally? |
Contributor
Author
|
@dschep they were passing locally for me, but I was running a hacked-up version of the circleci yaml file to run circleci locally using docker containers and most tests were passing (including the 3 new ones added here). Once it ran on the machine executor I had an issue with an older version of |
bspink
force-pushed
the
fix-zip-permissions
branch
3 times, most recently
from
fdac2e8 to
7e86c36
Compare
bspink
force-pushed
the
fix-zip-permissions
branch
from
7e86c36 to
68418ae
Compare
Contributor
Author
|
@dschep OK, fixed the tests - I was relying on hardcoded permissions values, but now grab them from the appropriate files dynamically. |
|
Nice work! This fixes an issue I'm seeing. When might this be published to npm? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #233