Speed up windows packaging #347
Conversation
Copying the files on windows is very slow and can be avoided by using junctions
This advice saved me a lot of time
|
Created issue to go with this PR |
| // Windows can't symlink so we have to use junction on Windows | ||
| if (process.platform == 'win32') { | ||
| fse.copySync(reqsInstalledAt, symlinkPath); | ||
| fse.symlink(reqsInstalledAt, symlinkPath, 'junction'); |
There was a problem hiding this comment.
Does this require any extra user permissions? I recall something about that
There was a problem hiding this comment.
It is my understanding that junctions only require the normal file creation permissions. When created they use fully qualified paths and can only link to directories in the same NTFS filesystem.
The admin permissions are required for a full symlink because this has more serious security complications.
The only potential problem I can see is if someone has set up their cache directory and the serverless directory on separate file systems. In that case the junction operation would fail. I could add this note to the readme, but it may be a lot of noise for an unlikely setup.
There was a problem hiding this comment.
Oh, very cool. I thought junctions were symlinks. Thanks for the clarification.
2 participants
Using junctions and adding a negative include pattern massively speed up the packaging time