Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

Conversation

@miketheman
Copy link
Contributor

Using MarkdownLint in VSCode, this file was showing many linter errors,
mostly around whitespace issues, but a few others that made it annoying
enough when looking at the file, it was inconsistent and difficult to
read.

Also handles a few existing notes about caching.

Refs #412
Resolves #420
Resolves #424

Signed-off-by: Mike Fiedler miketheman@gmail.com

Using MarkdownLint in VSCode, this file was showing many linter errors,
mostly around whitespace issues, but a few others that made it annoying
enough when looking at the file, it was inconsistent and difficult to
read.

Also handles a few existing notes about caching.

Refs serverless#412
Resolves serverless#420
Resolves serverless#424

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Copy link
Contributor

@bsamuel-ui bsamuel-ui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used prettier to lint markdown in other projects, should we do that?

@bsamuel-ui bsamuel-ui merged commit f334de7 into serverless:master Feb 22, 2020
@miketheman miketheman deleted the miketheman/update-readme branch February 22, 2020 16:37
@miketheman
Copy link
Contributor Author

I've used prettier to lint markdown in other projects, should we do that?

ooh, good call! I can add that to the Lint scope and test.

miketheman added a commit to miketheman/serverless-python-requirements that referenced this pull request Feb 22, 2020
Updates commands to catch when Markdown is malformed.

Refs: serverless#471 (review)

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading README instructions about using caches

2 participants