fix: nesting-tracking in resolver aborting too eagerly

[steven-noorbergen]

Closes: #10549

This is a minor change to the resolver that removes a false-positive nesting depth error.

When importing a file from a js function (using resolveVariable), all variables in that file are resolved in a loop. The loop passes a nest depth of one lower, but did so by decrementing the loop counter on each iteration. This means that once you hit your 10th variable, it aborts because it thinks you've nested to deep (while in fact you're still only one level deep).

Effectively this changes --nestTracker to nestTracker - 1, so that the actual depth is kept, allowing for normal behavior.

I also added a test case for this particular use-case. Note that while the test case does file inclusion inside the file-included file, it affects any variable resolving, but I did not want to mess with the test file too much.

[codecov]

Codecov Report

Merging #10554 (4948190) into master (1729e0f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #10554   +/-   ##
=======================================
  Coverage   85.82%   85.83%           
=======================================
  Files         335      335           
  Lines       13942    13942           
=======================================
+ Hits        11966    11967    +1     
+ Misses       1976     1975    -1     

Impacted Files	Coverage Δ
lib/configuration/variables/resolve.js	98.05% <100.00%> (+0.32%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1729e0f...4948190. Read the comment docs.

[pgrzesik]

Hello @steven-xaroth - we plan to release new major version very soon and for now we're "freezing" merging new features/fixes to the current master (v2) branch. We will let you know after v3 release, unfortunately there might be some changes needed on your side.

[medikoo]

@steven-xaroth that's a great find! Big thanks for proposing that PR

[medikoo]

@pgrzesik I think it's an important bug fix, that justifies another v2 release before v3. I propose to release it, also when I'll have #10551 done

[pgrzesik]

Thanks @medikoo 👍