Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't automatically parse input to JSON when using invoke and invoke local #3788

Closed
pmuens opened this issue Jun 13, 2017 · 2 comments
Closed

Comments

@pmuens
Copy link
Contributor

pmuens commented Jun 13, 2017

This is a Feature Proposal

Description

Currently we're assuming that the input for the invoke and invoke local command is a string which can be parsed (and will be parsed) into JSON.

However some AWS services assume other inputs.

We should update the invoke and invoke local command to reflect that (see: #2833 (comment) and #2833 (comment)).

Thanks @wxs and @dzimine for bringing this up 👍

@dzimine
Copy link
Contributor

dzimine commented Aug 3, 2017

Please take a look at the PR #4036 and see if you're ok with:

  1. parsing by default - my reason is "not break current user's experience", someone may be using it already.
  2. --raw - happy to take a better suggestion

@pmuens
Copy link
Contributor Author

pmuens commented Aug 3, 2017

Please take a look at the PR #4036

Great! Thanks for taking a stab at it @dzimine 🎉. The implementation sounds reasonable 👍.

We'll look into it ASAP!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants