Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP API Support #7052

Open
jplock opened this issue Dec 5, 2019 · 15 comments
Open

HTTP API Support #7052

jplock opened this issue Dec 5, 2019 · 15 comments
Assignees

Comments

@jplock
Copy link

@jplock jplock commented Dec 5, 2019

Feature Proposal

Description

https://aws.amazon.com/blogs/compute/announcing-http-apis-for-amazon-api-gateway/

  1. It would be nice if a Serverless application could use the new HTTP APIs exclusively somehow to get the cost benefits.
@Gr8z

This comment has been minimized.

Copy link

@Gr8z Gr8z commented Dec 9, 2019

+1

2 similar comments
@MasterCassim

This comment has been minimized.

Copy link

@MasterCassim MasterCassim commented Dec 9, 2019

+1

@riseres

This comment has been minimized.

Copy link

@riseres riseres commented Dec 10, 2019

+1

@majoraze

This comment has been minimized.

Copy link

@majoraze majoraze commented Dec 11, 2019

I believe the challenge will be supporting the other event types, if you have 1 lambda with 2 events of type http and type SQS, it will have to create 2 different api gateways right? One for the HTTP API event and another in the old format for the SQS event. So there will be 2 different api gateways for the same function..

@MasterCassim

This comment has been minimized.

Copy link

@MasterCassim MasterCassim commented Dec 11, 2019

I would just reject the configuration.

In my opinion, you would configure which API to use in the configuration file. If there are some features used which are not supported, the configuration should be rejected.

@medikoo medikoo removed the help wanted label Dec 12, 2019
@waynerobinson

This comment has been minimized.

Copy link

@waynerobinson waynerobinson commented Dec 16, 2019

Only HTTP events need API Gateway configuration. All the other event types have their own event configuration that don't go through API Gateway.

You'd only ever require both a v1 and v2 API Gateway config if you specifically wanted events in both (v1 does have a lot more features than v2… but the downside is cost and latency).

@vladgolubev

This comment has been minimized.

Copy link
Contributor

@vladgolubev vladgolubev commented Dec 17, 2019

Looks like CloudFormation support just landed: https://aws.amazon.com/about-aws/whats-new/2019/12/aws-cloudformation-updates-for-api-gateway-codepipeline-s3-iam-ecs-rds-es-lambda-and-more/

Create an HTTP API, JSON web tokens (JWTs) Authorizer and stage for HTTP API, and specify VPC endpoint IDs of an API to create Route53 aliases in Amazon API Gateway.

@ngoyal16

This comment has been minimized.

Copy link

@ngoyal16 ngoyal16 commented Dec 28, 2019

+1

1 similar comment
@toyama0919

This comment has been minimized.

Copy link

@toyama0919 toyama0919 commented Dec 31, 2019

+1

@bionicles

This comment has been minimized.

Copy link

@bionicles bionicles commented Jan 2, 2020

It’s agonizing to wait months for new features to be added to infrastructure as code tools

@hakimio

This comment has been minimized.

Copy link

@hakimio hakimio commented Jan 2, 2020

@bionicles if it's so urgent for you, create a PR - it's open source community project. What are you waiting for?

@jplock

This comment has been minimized.

Copy link
Author

@jplock jplock commented Jan 3, 2020

@medikoo @pmuens could we get some guidenance from the Serverless team on how you might like this to work if somewhere were to create a PR for your review? Would you like to only support http endpoints and reject the configuration if there are other event types, etc.?

@medikoo

This comment has been minimized.

Copy link
Member

@medikoo medikoo commented Jan 9, 2020

@jplock We we will propose an implementation spec proposal next week, and actual implementation work should follow up shortly after we agree on most important details.

@medikoo medikoo self-assigned this Jan 9, 2020
@bionicles

This comment has been minimized.

Copy link

@bionicles bionicles commented Jan 10, 2020

@hakimio Downvote as you wish but it’s unfair to expect folks who’ve never made a PR on a large software project to learn the inner workings of a codebase to add critical features for free. The maintainers of the repo are responsible for the code within, not new users.

There are a lot of options for infrastructure as code today (Pulumi, CDK, Terraform, Cloudformation, SAM) ... and “Serverless” appears to be a for-profit business, so surely independent unpaid developers are not expected to provide core functionality?

We’d all prefer this feature were added by someone who had already contributed to the repo. Sorry if my disappointment with the delay hurt your feelings.

Thanks for the downvotes, it’s fun to strike a nerve

@garethmcc garethmcc closed this Jan 20, 2020
@garethmcc garethmcc reopened this Jan 20, 2020
@garethmcc

This comment has been minimized.

Copy link

@garethmcc garethmcc commented Jan 20, 2020

Accidentally closed while trying to comment, apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.