New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add rollbackConfiguration #7193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @birdie697 looks as a great enhancement !
Can you ensure that proposed changes match prettier formatting (currently CI fails as they doesn't).
You can easily patch that via npm run prettify:updated
Codecov Report
@@ Coverage Diff @@
## master #7193 +/- ##
==========================================
+ Coverage 87.99% 88.16% +0.16%
==========================================
Files 236 236
Lines 8608 8644 +36
==========================================
+ Hits 7575 7621 +46
+ Misses 1033 1023 -10
Continue to review full report at Codecov.
|
@medikoo thank you for the feedback and the suggestion to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @birdie697 looks great to me!
@pmuens can you give it a second look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks @birdie697 👍
What did you implement
Adds support for rollbackConfiguration
Closes #7134
How can we verify it
A unit test was written to cover this change.
Todos
Is this ready for review?: YES
Is it a breaking change?: NO