Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rollbackConfiguration #7193

Merged
merged 2 commits into from Jan 9, 2020
Merged

add rollbackConfiguration #7193

merged 2 commits into from Jan 9, 2020

Conversation

birdie697
Copy link
Contributor

What did you implement

Adds support for rollbackConfiguration

Closes #7134

How can we verify it

A unit test was written to cover this change.

Todos

  • Write and run all tests
  • Write documentation
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @birdie697 looks as a great enhancement !

Can you ensure that proposed changes match prettier formatting (currently CI fails as they doesn't).
You can easily patch that via npm run prettify:updated

@codecov-io
Copy link

codecov-io commented Jan 9, 2020

Codecov Report

Merging #7193 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7193      +/-   ##
==========================================
+ Coverage   87.99%   88.16%   +0.16%     
==========================================
  Files         236      236              
  Lines        8608     8644      +36     
==========================================
+ Hits         7575     7621      +46     
+ Misses       1033     1023      -10
Impacted Files Coverage Δ
lib/plugins/aws/lib/updateStack.js 98.11% <100%> (+0.07%) ⬆️
lib/plugins/package/lib/packageService.js 86.06% <0%> (-1.44%) ⬇️
lib/plugins/aws/package/compile/functions/index.js 96.73% <0%> (ø) ⬆️
lib/plugins/aws/invokeLocal/index.js 77% <0%> (ø) ⬆️
lib/plugins/aws/lib/naming.js 97.81% <0%> (+0.08%) ⬆️
lib/plugins/aws/provider/awsProvider.js 93% <0%> (+0.14%) ⬆️
...ins/aws/package/compile/events/cloudFront/index.js 100% <0%> (+10.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f9f808...b83d6c7. Read the comment docs.

@birdie697
Copy link
Contributor Author

@medikoo thank you for the feedback and the suggestion to use npm run prettify:updated. That did not trigger any changes in the file. I am using Webstorm and "Reformat with Prettier" changed the file that passed the CI tests. I appreciate your time in reviewing this PR.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @birdie697 looks great to me!

@pmuens can you give it a second look?

@medikoo medikoo requested a review from pmuens January 9, 2020 14:52
Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @birdie697 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Stack Rollback Configuration
4 participants