SQS 'Enabled' should be of type 'Boolean' #7532
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement
The
Enabled
property on theSQS
resource was typed as astring
but should be aboolean
Closes #7438
How can we verify it
Input
serverless.yml
Run
> sls package
Output
cloudformation-template-update-stack.json
Enabled is now being set to a boolean
Before the change
cloudformation-template-update-stack.json
Enabled was being set to a string
Todos
Useful Scripts
npm run test:ci
--> Run all validation checks on proposed changesnpm run lint:updated
--> Lint all the updated filesnpm run lint:fix
--> Automatically fix lint problems (if possible)npm run prettier-check:updated
--> Check if updated files adhere to Prettier confignpm run prettify:updated
--> Prettify all the updated filesIs this ready for review?: YES
Is it a breaking change?: POTENTIALLY
I'm unsure how CloudFormation would have handled this property being set to a string.
For example did CloudFormation treat
"Enabled": 'True'
astrue
orfalse