Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable CloudWatch Log Group per function #7720

Merged
merged 5 commits into from May 13, 2020
Merged

Disable CloudWatch Log Group per function #7720

merged 5 commits into from May 13, 2020

Conversation

AhmedFat7y
Copy link
Contributor

Closes: #7599

medikoo
medikoo suggested changes May 12, 2020
View reviewed changes
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AhmedFat7y ! It looks really good. Please see my remarks and let me know what you think

lib/plugins/aws/package/lib/mergeIamTemplates.js Outdated Show resolved Hide resolved
lib/plugins/aws/package/lib/mergeIamTemplates.test.js Outdated Show resolved Hide resolved
@medikoo
Copy link
Contributor

medikoo commented May 12, 2020

Additionally it'll be great to have it documented in:

@AhmedFat7y
Copy link
Contributor Author

I added it here docs/providers/aws/guide/functions.md in the Log Group Resources section. I will add it to this one as well docs/providers/aws/guide/serverless.yml.md

@AhmedFat7y
Copy link
Contributor Author

@medikoo Should I add these fixes as new commits or rebase and force push for cleaner history?

Exclude functions with disableLogs from log group creation
f698d0e 
Change disableLogs flag tests to use runServerless

Ignore test fixtures .serverless dir

Modify docs to include disableLogs flag
@medikoo
Copy link
Contributor

medikoo commented May 12, 2020

@medikoo Should I add these fixes as new commits or rebase and force push for cleaner history?

No there's no need. We will anyway make one squash commit out of it

@AhmedFat7y AhmedFat7y requested a review from medikoo May 12, 2020 18:22
medikoo
medikoo approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@medikoo medikoo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AhmedFat7y Thank you! Looks great!

One side note: It appears that on your machine you don't have git setup with your email address. Note that your commits are not bound to your GitHub account (no avatar by them)

@medikoo medikoo merged commit 3144be8 into serverless:master May 13, 2020
@AhmedFat7y
Copy link
Contributor Author

Hahahahahaha
I’m using a temp windows machine. It is very annoying and I’m trying not to play around too much 😂

@AhmedFat7y AhmedFat7y deleted the disable_logs_per_function branch May 14, 2020 19:10
@AhmedFat7y AhmedFat7y mentioned this pull request May 14, 2020
Merged
@medikoo medikoo mentioned this pull request Jun 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medikoo medikoo medikoo approved these changes

Assignees

@AhmedFat7y AhmedFat7y

Labels
cat/lambda enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Turn off CloudWatch Log Group creation for _specific_ functions.
2 participants
@AhmedFat7y @medikoo