Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Schema: Report configuration errors as warnings #8101

Merged
merged 1 commit into from Aug 19, 2020

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Aug 19, 2020

Closes: #8084

Additionally all configuration errors are reported as warnings, as by default they behave as warnings (let process continue), while "error" gives an impression action was stopped.

By default they behave as warnings (let process continue), while "error" gives an impression action was stopped
@medikoo medikoo added bug/design Functionality design flaw cat/config-schema labels Aug 19, 2020
@medikoo medikoo self-assigned this Aug 19, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #8101 into master will decrease coverage by 0.01%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8101      +/-   ##
==========================================
- Coverage   88.33%   88.31%   -0.02%     
==========================================
  Files         248      248              
  Lines        9445     9450       +5     
==========================================
+ Hits         8343     8346       +3     
- Misses       1102     1104       +2     
Impacted Files Coverage Δ
lib/classes/ConfigSchemaHandler/index.js 84.78% <37.50%> (-1.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b892a97...cd4e273. Read the comment docs.

@medikoo medikoo merged commit e1ee0dc into master Aug 19, 2020
@medikoo medikoo deleted the 0819-improve-config-warnings branch August 19, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/design Functionality design flaw cat/config-schema
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve "Unrecognized provider" warning
2 participants