Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure Provider Support #1426

Closed
wants to merge 28 commits into from

Conversation

felixrieseberg
Copy link

Hey everyone, your friendly Microsoft Open Source team with a little PR - adding support for Azure. We understand that stuff is still in development, but getting Azure into the development pipeline earlier rather than later is probably a good idea.

  • Full compile/deploy/remove/invoke support
  • Unit tests where appropriate
  • No integration tests (yet)

@felixrieseberg felixrieseberg force-pushed the v1.0-azure branch 3 times, most recently from 0b37dfd to cc53cba Compare June 28, 2016 05:58
@ac360
Copy link
Member

ac360 commented Jun 28, 2016

Awesome work @felixrieseberg @bnookala @timfpark @mattpodwysocki ! Really well done guys :)

@pmuens
Copy link
Contributor

pmuens commented Jun 28, 2016

This is awesome! Thank you so much guys! We'll look into it ASAP! 🎉

@eahefnawy
Copy link
Member

Sweeeet! Thanks tons @felixrieseberg 😊 💃 👯

if (functionObject.events.azure.http_endpoint) {
functionJSON = HttpTrigger.buildFunctionJSON(functionObject);
} else if (functionObject.events.azure.scheduled_trigger) {
functionJSON = TimerTrigger.buildFunctionJSON(TimerTrigger);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be missing the context here but should this be....

functionJSON = TimerTrigger.buildFunctionJSON(functionObject);

It looks like you're passing in the TimerTrigger object to itself?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jthomas D'oh. This is me. I'll fix this!

@pmuens
Copy link
Contributor

pmuens commented Jul 12, 2016

Thanks for this amazing work! 🎉 We've recently pulled it into a local branch and will update / work on it there (see #1547).

@pmuens pmuens closed this Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants