Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure support #1547

Closed
wants to merge 34 commits into from
Closed

Azure support #1547

wants to merge 34 commits into from

Conversation

@pmuens
Copy link
Contributor

@pmuens pmuens commented Jul 12, 2016

PR to add Microsoft Azure support.

This is a rebased version of the original PR by the Amazing Microsoft OS team (#1426). We've pulled it in to update it according to the recent changes.

Here's the corresponding issue which outlines what will be changed: #1493

@pmuens pmuens added this to the v1.0.0-alpha.3 milestone Jul 12, 2016
@eahefnawy eahefnawy mentioned this pull request Jul 12, 2016
5 of 20 tasks complete
@pmuens pmuens force-pushed the v1.0-azure branch 3 times, most recently from 66d9cf2 to 65fbf90 Jul 12, 2016
@pmuens pmuens force-pushed the v1.0-azure branch from 65fbf90 to 37502cc Jul 13, 2016
@pmuens pmuens modified the milestones: v1.0, v1.0.0-beta Jul 22, 2016
uploadZipFiles() {
this.serverless.cli.log('Uploading zip files to Azure...');
const targetWebsite = this.serverless.service.resources.azure.variables.sitename;
const user = process.env.AZURE_USERNAME;

This comment has been minimized.

@christopheranderson

christopheranderson Aug 10, 2016

Should be able to get deployment credentials from ARM (.../Microsoft.Web/sites/*/config/publishingcredentials). Asking users to fetch this and set env variables isn't going to be smooth, from experience.

@flomotlik flomotlik closed this Aug 12, 2016
@flomotlik
Copy link
Contributor

@flomotlik flomotlik commented Aug 12, 2016

closed because of V1 branch being removed. Could you reopen against master?

@pmuens pmuens changed the base branch from v1.0 to master Aug 16, 2016
@pmuens pmuens reopened this Aug 16, 2016
@mi-hol
Copy link

@mi-hol mi-hol commented Oct 28, 2016

@pmuens , @flomotlik I wonder if the label 'in-review' is actually correct because it doesn't show activity on the project 'Pull Request Pipeline'. Milestone 'v1.0-ideas' seems no longer relevant either hence , knowing a timeline for merge would be very valueable :)

@pmuens pmuens removed the in-review label Oct 29, 2016
@pmuens
Copy link
Contributor Author

@pmuens pmuens commented Oct 29, 2016

Hey @mi-hol thank you for your comment and the pointers! 👍

We're working on and investigating multi provider support for the Serverless framework (see this PR, #1858 and #2568) for upcoming releases.

Unfortunately this PR is a little bit outdated since the Serverless Framework moved fast the last couple of weeks / months so it needs some updates so that it's ready to be merged.

@mi-hol
Copy link

@mi-hol mi-hol commented Oct 29, 2016

Hi @pmuens, Thanks for explaining
Hi @felixrieseberg , @christopheranderson what is your view on progress & issues of this PR?

@flomotlik flomotlik modified the milestone: v1.0-ideas Nov 4, 2016
@mi-hol
Copy link

@mi-hol mi-hol commented Nov 15, 2016

@pmuens it would seem that the original authors either lost interest or are unavailable.
Are you in a position to share plans for supporting Azure?

@pmuens
Copy link
Contributor Author

@pmuens pmuens commented Nov 15, 2016

Hey @mi-hol thanks for getting back! 👍
Multi provider support is still a very high priority for us. We're currently moving some of those PRs into own plugins (and already finished some) so that our main codebase is clean and every provider is integrated via a plugin.

This PR is a little bit outdated but we'll fix it and migrate it pretty soon!

@pmuens
Copy link
Contributor Author

@pmuens pmuens commented Dec 8, 2016

Azure support will be implemented in a separate plugin by the awesome folks from Microsoft. 🎉

Here's the link to the repository: https://github.com/serverless/serverless-azure-functions

@pmuens pmuens closed this Dec 8, 2016
@pmuens pmuens deleted the v1.0-azure branch Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants