Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy necessary permission grant command to azure quickstart guide #3477

Merged
merged 1 commit into from Apr 17, 2017

Conversation

@Harrison-M
Copy link
Contributor

commented Apr 16, 2017

What did you implement:

As written prior to this commit, the Azure quickstart guide does not grant the created service principal access to perform a deploy.

How did you implement it:

I copied the relevant instructions from the Azure credentials guide into the quickstart guide. The credential section of the quickstart guide was previously identical to the credential guide apart from the section I copied in.

How can we verify it:

Follow the instructions in the quickstart guide and verify that serverless invoke -f hello produces the output "Hello World"

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

@pmuens

This comment has been minimized.

Copy link
Member

commented Apr 17, 2017

Good one! Thanks @Harrison-M 👍

@pmuens pmuens merged commit 1bc0ce6 into serverless:master Apr 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pmuens pmuens modified the milestone: 1.12 Apr 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.