Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add function artifact check in deployFunction #3856
What did you implement:
How did you implement it:
Added function artifact check in
How can we verify it:
Is this ready for review?: YES
Thanks for fixing this @darkowlzz
This looks pretty promising. I've tested it with a couple of different setups and couldn't break it. However I'll test it more thoroughly the upcoming days.
I added a comment about a missing test case. Other than that I believe it should be GTM quite soon!
Let us know if you need any help here!
Thanks for updating the PR @darkowlzz
I just looked through the code and my assumption is that root cause of the weir behavior is that one of the tests here fails and the stubs are not resettet which means that e.g.
I added some comments. Generally speaking all the stub usages should be moved into
You can find an example here:
That ensures that the stubs are always correctly setup and always restored correctly.
I have not tested it thoroughly yet. Will do this next up.
Let us know if you still face any other roadblocks
Hey @darkowlzz thanks for updating this PR again
I just took a deep dive today and added some more comments to the PR.
Unfortunately I was able to break it with the following
service: name: test-service provider: name: aws runtime: nodejs6.10 package: individually: true functions: hello: handler: handler.hello package: artifact: artifacts/hello.zip
@eahefnawy could you also take a deep dive into this PR and test all the possible edge cases?
Thanks again @darkowlzz
@pmuens that was happening because of how the
Thanks for all the work you've put into this @darkowlzz
I just pushed some minor changes regarding tests to this PR and reviewed / tested it thoroughly this morning.
Wasn't able to break it. Here's the service which I used (I un/commented different parts during the tests):
service: name: test-service provider: name: aws runtime: nodejs6.10 package: individually: true functions: hello: handler: handler.hello package: artifact: artifacts/hello.zip goodbye: handler: handler.goodbye package: artifact: artifacts/goodbye.zip
GTM from my side
Leaving the stage for @eahefnawy to test and merge it if he won't find anything else
@pmuens could you try to reproduce? with the following config:
@eahefnawy thanks for the in-depth test and the list with the different cases you've tested against.
I was able to reproduce the issue. However this issue is also in
@eahefnawy could you try to reproduce the issue in