New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installs @types/aws-lambda and uses types in handler, per issue #4546 #4552

Merged
merged 1 commit into from Dec 11, 2017

Conversation

Projects
None yet
4 participants
@jamestharpe

jamestharpe commented Dec 11, 2017

What did you implement:

Closes #4546

How did you implement it:

I added the required configuration to include @types/aws-lambda as a dev dependency and updated handler.ts to make use of the Handler, Callback, and Context types.

How can we verify it:

Use the template and call npm install:

serverless create --template aws-nodejs-typescript && npm install

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@HyperBrain

LGTM

@horike37

horike37 approved these changes Dec 11, 2017 edited

Thanks @jamestharpe for your first contribution 👍
I tested it locally and works fine 💯
LGTM

@horike37 horike37 added this to the 1.25 milestone Dec 11, 2017

@horike37 horike37 merged commit 24ce96d into serverless:master Dec 11, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 87.961%
Details

@HyperBrain HyperBrain removed this from the 1.25 milestone Dec 14, 2017

@pmuens pmuens added this to the 1.25 milestone Dec 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment