New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tab completion for slss shortcut #4712

Merged
merged 1 commit into from Jan 23, 2019

Conversation

@drexler
Copy link
Contributor

drexler commented Feb 3, 2018

What did you implement:

Closes #4671

How did you implement it:

How can we verify it:

Todos:

  • Make sure code coverage hasn't dropped
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@pmuens

pmuens approved these changes Jan 23, 2019

Copy link
Member

pmuens left a comment

Great. Thanks for adding this @drexler 👍

LGTM :shipit:

@pmuens pmuens changed the title enable tab completion for slss shortcut Enable tab completion for slss shortcut Jan 23, 2019

@pmuens pmuens self-assigned this Jan 23, 2019

@pmuens pmuens added this to In progress in Serverless via automation Jan 23, 2019

@eahefnawy
Copy link
Member

eahefnawy left a comment

Thanks @drexler ... and sorry for the very late response.

We're prepping a patch release right now, and we will merge this after.

Serverless automation moved this from In progress to Reviewer approved Jan 23, 2019

@pmuens pmuens merged commit 90717e0 into serverless:master Jan 23, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 88.535%
Details

Serverless automation moved this from Reviewer approved to Done Jan 23, 2019

@pmuens pmuens added this to the 1.36.4 milestone Feb 5, 2019

@Gerst20051

This comment has been minimized.

Copy link

Gerst20051 commented Feb 13, 2019

it's funny how this was merged in yet still no resolution to being able to disable tab tab autocompletions from being installed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment