New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaks in `aws-scala-sbt` #5004

Merged

horike37 merged 1 commit into serverless:master from NomadBlacky:tweaks-in-aws-scala-sbt

Jun 12, 2018

NomadBlacky commented May 27, 2018 •

edited

Loading

What did you implement:

Closes #XXXXX

Tab characters and spaces are mixed in Scala code.

How did you implement it:

Fix tab characters to spaces in Scala code.

How can we verify it:

Todos:

Write tests
Write documentation
Fix linting errors
Make sure code coverage hasn't dropped
Provide verification config / commands / resources
Enable "Allow edits from maintainers" for this PR
Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO


          Fix tab characters to spaces in aws-scala-sbt

6fe110a

Author

NomadBlacky commented May 27, 2018

Oops! coverage/coveralls failed...
Why is that?

horike37 approved these changes

View reviewed changes

Contributor

horike37 left a comment

@NomadBlacky
Thank you for the improvement 👍
LGTM 💯

horike37 added this to the 1.28 milestone

horike37 merged commit 9f0ff90 into serverless:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet