Skip to content

Tweaks in aws-scala-sbt - #5004

Merged
horike37 merged 1 commit into
serverless:masterfrom
NomadBlacky:tweaks-in-aws-scala-sbt
Jun 12, 2018
Merged

Tweaks in aws-scala-sbt#5004
horike37 merged 1 commit into
serverless:masterfrom
NomadBlacky:tweaks-in-aws-scala-sbt

Conversation

@NomadBlacky

@NomadBlacky NomadBlacky commented May 27, 2018

Copy link
Copy Markdown

What did you implement:

Closes #XXXXX

  • Tab characters and spaces are mixed in Scala code.

How did you implement it:

  • Fix tab characters to spaces in Scala code.

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@NomadBlacky

Copy link
Copy Markdown
Author

Oops! coverage/coveralls failed...
Why is that?

@horike37 horike37 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NomadBlacky
Thank you for the improvement 👍
LGTM 💯

@horike37 horike37 added this to the 1.28 milestone Jun 12, 2018
@horike37
horike37 merged commit 9f0ff90 into serverless:master Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants