Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve aws-scala-sbt template #5086

Merged
merged 3 commits into from
Jul 17, 2018

Conversation

NomadBlacky
Copy link

What did you implement:

Closes #XXXXX

  • Improve aws-scala-sbt template.

How did you implement it:

How can we verify it:

$ sls create -t aws-scala-sbt -p sls-scala
$ cd sls-scala
$ sbt sbtVersion # Please check the display of `1.1.6`
$ sbt scalaVersion # Please check the display of `2.12.6`
$ sbt assembly
$ sls deploy
$ sls invoke -f hello

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

Copy link
Contributor

@horike37 horike37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NomadBlacky
Works great 👍 Thank you for your contribution!
merging...

@horike37 horike37 added this to the 1.29 milestone Jul 17, 2018
@horike37 horike37 merged commit dbb9bae into serverless:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants