New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Kubeless secrets #5130

Merged
merged 1 commit into from Jan 16, 2019

Conversation

Projects
None yet
4 participants
@alexander-alvarez
Copy link
Contributor

alexander-alvarez commented Jul 17, 2018

What did you implement:

Added documentation for Kubeless secrets

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@pmuens

pmuens approved these changes Jan 16, 2019

Copy link
Member

pmuens left a comment

Good stuff! THanks for working on this @alexander-alvarez 👍

LGTM :shipit:

@pmuens pmuens merged commit f2038ae into serverless:master Jan 16, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 87.024%
Details

@shortjared shortjared added this to the v1.36.2 milestone Jan 22, 2019

@shortjared shortjared added the docs label Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment