Update AWS TypeScript handler template #5309
Merged
+3
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| export const hello: Handler = (event: APIGatewayEvent, context: Context, cb: Callback) => { | ||
| const response = { | ||
| export const hello: APIGatewayProxyHandler = async (event, context) => { |
There was a problem hiding this comment.
Why did you remove the types from the function parameters?
There was a problem hiding this comment.
in the current template, it was necessary to explicitly indicate the type of the arguments -- that's because the used insufficient type Handler.
now, by storing function to the constant of type APIGatewayProxyHandler, the types of event and context are implicitly inferred. Please see the attached image.
There was a problem hiding this comment.
hi @uneco
Thanks for the explanation.
Just saw https://github.com/DefinitelyTyped/DefinitelyTyped/blob/b697ec8a1bb26313b4d56a0af66b9c45c9920cef/types/aws-lambda/index.d.ts#L814 after your explanation and I understood.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
aws-nodejs-typescripthandler template of new notation similar to:https://github.com/serverless/serverless/blob/master/lib/plugins/create/templates/aws-nodejs/handler.js
How did you implement it:
Just like the js version
How can we verify it:
sls create --template aws-nodejs-typescriptTodos:
Is this ready for review?: YES
Is it a breaking change?: NO