New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gitignore setting to Go template #5386

Merged
merged 1 commit into from Oct 13, 2018

Conversation

Projects
None yet
2 participants
@toshi0607
Copy link
Contributor

toshi0607 commented Oct 13, 2018

What did you implement:

Closes #XXXXX

no issue

This PR is adding settings to .gitignore of Go templates. The content is based on a github/gitignore repository.

The existing setting is only for serverless framework. I'd like to add general golang settings.

How did you implement it:

Add files that should be ignored on git.

How can we verify it:

$ cd $GOPATH/src/github.com/[your repo]
$ serverless create -t aws-go-dep -p sample-app
$ cd sample-app
$ git init
$ touch sample.test
$ git status
# sample.test is not tracked

Todos:

- [ ] Write tests

  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@horike37 horike37 added this to the 1.33.0 milestone Oct 13, 2018

@horike37
Copy link
Member

horike37 left a comment

@toshi0607
LGTM 👍
These improvements have been shipped in an upcoming release!

AWESOME 💯 🎉

@horike37 horike37 merged commit ac6656e into serverless:master Oct 13, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 91.085%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment