New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uploaded file name to log while AWS deploy #5495

Merged
merged 2 commits into from Jan 23, 2019

Conversation

Projects
3 participants
@Enase
Copy link

Enase commented Nov 15, 2018

What did you implement:

Closes #5358

Add uploaded filename to console while while uploading services

How did you implement it:

Filename added to console output

Examples:
see #5358

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@pmuens
Copy link
Member

pmuens left a comment

This looks good. Thanks for working on this @Enase 👍

I think it should be GTM once the conflicts are resolved.

@pmuens pmuens self-assigned this Jan 23, 2019

@pmuens pmuens added this to In progress in Serverless via automation Jan 23, 2019

@pmuens pmuens dismissed their stale review via c9a321d Jan 23, 2019

Serverless automation moved this from In progress to Needs review Jan 23, 2019

@pmuens

pmuens approved these changes Jan 23, 2019

Copy link
Member

pmuens left a comment

Resolved the conflicts. Merging... :shipit:

Serverless automation moved this from Needs review to Reviewer approved Jan 23, 2019

@pmuens pmuens merged commit 3c5e5a2 into serverless:master Jan 23, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0008%) to 93.006%
Details

Serverless automation moved this from Reviewer approved to Done Jan 23, 2019

@pmuens pmuens added this to the 1.36.4 milestone Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment