New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3.7 support!!! #5505

Merged
merged 2 commits into from Nov 20, 2018

Conversation

Projects
None yet
2 participants
@dschep
Member

dschep commented Nov 19, 2018

AWS now supports Python3.7 in Lambda!
https://aws.amazon.com/blogs/compute/python-3-7-runtime-now-available-in-aws-lambda/

What did you implement:

Updated the python3 template to use the python3.7 runtime & invoke local to support it too.

How did you implement it:

  • replaced string in python3 template
  • changed check for python runtime in invoke local

How can we verify it:

npm i -g serverless/serverless#python3.7
sls create -t aws-python3 -n py37 -p py37
cd py37
sls deploy
sls invoke local -f hello
sls invoke -f hello

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@dschep dschep requested a review from alexdebrie Nov 19, 2018

@alexdebrie

LGTM!

Only other potential change I can see is here: https://github.com/serverless/serverless/blob/master/docker-compose.yml#L35. I've never used the docker-compose.yml though so not sure if necessary.

@alexdebrie

LGTM!

@dschep dschep merged commit 1bef883 into master Nov 20, 2018

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 91.138%
Details

@dschep dschep deleted the python3.7 branch Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment