New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 2.5 support in AWS Lambda #5546

Merged
merged 2 commits into from Nov 30, 2018

Conversation

Projects
None yet
6 participants
@BigChief45
Contributor

BigChief45 commented Nov 29, 2018

https://aws.amazon.com/about-aws/whats-new/2018/11/aws-lambda-supports-ruby/

Not sure if there are things that have to be added to docker-compose.yml.

What did you implement:

Closes #5540

How can we verify it:

serverless create --template aws-ruby
serverless deploy
serverless invoke -f hello

Is this ready for review?: YES
Is it a breaking change?: NO

@BigChief45 BigChief45 changed the title from :gem: :gem: :gem: Add Ruby 2.5 support in AWS Lambda to Add Ruby 2.5 support in AWS Lambda Nov 29, 2018

@dschep dschep referenced this pull request Nov 29, 2018

Closed

Ruby template! #5544

6 of 7 tasks complete
@dschep

This comment has been minimized.

Member

dschep commented Nov 29, 2018

I already had a PR over at #5544 but this is more complete! Thanks 👍

@dschep

This comment has been minimized.

Member

dschep commented Nov 29, 2018

Everything look good here @horike37 ?

@@ -0,0 +1,50 @@
*.gem

This comment has been minimized.

@dschep

dschep Nov 29, 2018

Member

Actually.. counter to what @horike37 mentioned on my PR. I think this should be gitignore not .gitignore. Look at all the other runtime templates 😉

This comment has been minimized.

@PedroSeda

PedroSeda Nov 30, 2018

if (fse.existsSync(path.join(process.cwd(), 'gitignore'))) {
fse.renameSync(path.join(process.cwd(), 'gitignore'),
path.join(process.cwd(), '.gitignore'));

I agree with @dschep on this one.
Other then that, great work @BigChief45, looking forward to use it.

@horike37

This comment has been minimized.

Member

horike37 commented Nov 29, 2018

I just tested and it works! awesome @BigChief45 👍 The code looks good from my perspective 💯
We can merge this if what @dschep mentioned above will be resolved

@dschep

dschep approved these changes Nov 30, 2018

@dschep

Doh. it's too early in the morning. I stll want git mv .gitignore gitignore

@dschep

dschep approved these changes Nov 30, 2018

@dschep dschep merged commit 5d9cfa9 into serverless:master Nov 30, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 90.736%
Details
@BigChief45

This comment has been minimized.

Contributor

BigChief45 commented Nov 30, 2018

Oops completely missed the undotted gitignore! Thanks guys.

@BigChief45 BigChief45 deleted the BigChief45:ruby-support branch Nov 30, 2018

@rupakg

This comment has been minimized.

Contributor

rupakg commented Nov 30, 2018

Good work everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment