New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logRetentionInDays regression in AWS #5562

Merged
merged 3 commits into from Dec 5, 2018

Conversation

Projects
None yet
2 participants
@exoego
Copy link
Contributor

exoego commented Dec 5, 2018

What did you implement:

Closes #5534

How did you implement it:

Parsing logRetentionInDays as Integer.
If it is a numeric string like "42", it is accepeted as integer.

How can we verify it:

I think the test code is sufficient to verify, since it is just fixing trivial regression of type mis-handling.

Todos:

  • Write tests
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@exoego exoego changed the title Log retenion regression Fix logRetentionInDays regression in AWS Dec 5, 2018

@dschep

dschep approved these changes Dec 5, 2018

@dschep dschep merged commit 00756dd into serverless:master Dec 5, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@exoego exoego deleted the exoego:log-retenion-regression branch Dec 8, 2018

@dschep dschep referenced this pull request Dec 12, 2018

Merged

v1.35.0 release! #5592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment