New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set reserved concurrency in cfn template even if zero #5566

Merged
merged 1 commit into from Dec 5, 2018

Conversation

Projects
None yet
2 participants
@dschep
Copy link
Member

dschep commented Dec 5, 2018

What did you implement:

fixes #5402

How did you implement it:

change the check to be for truthyness or === 0

How can we verify it:

  1. make service with a lambda with zero concurrency
  2. sls package
  3. check that it is set in the cfn template inside .serverless

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@dschep dschep requested review from horike37 , eahefnawy and pmuens Dec 5, 2018

@alexdebrie
Copy link
Contributor

alexdebrie left a comment

LGTM!

@dschep dschep merged commit 6421135 into master Dec 5, 2018

3 of 4 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@dschep dschep deleted the app-5402 branch Dec 5, 2018

@dschep dschep referenced this pull request Dec 12, 2018

Merged

v1.35.0 release! #5592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment