New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template for provided runtime with the bash sample from AWS #5577

Merged
merged 2 commits into from Jan 25, 2019

Conversation

Projects
3 participants
@dschep
Copy link
Member

dschep commented Dec 7, 2018

What did you implement:

Added an aws-provided template including AWS's bash example of using the Runtime API

How did you implement it:

  • added template to create plugin
  • added to list of templates(todo)

How can we verify it:

npm i -g serverless/serverless#provided-template
sls create -t aws-provided
sls deploy
sls invoke -f hello

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@pmuens
Copy link
Member

pmuens left a comment

Looks like we're pretty close to get this merged 👌

Do you want to continue the work here @dschep or should I take it from here?

@pmuens pmuens changed the title [WIP] a template for provided runtime with the bash sample from AWS Add template for provided runtime with the bash sample from AWS Jan 23, 2019

@dschep dschep force-pushed the provided-template branch from b57af26 to 748dad8 Jan 23, 2019

@dschep

This comment has been minimized.

Copy link
Member Author

dschep commented Jan 23, 2019

Thanks for the nudge @pmuens, should be GTM now 🙂

@pmuens

pmuens approved these changes Jan 25, 2019

Copy link
Member

pmuens left a comment

Thanks for updating @dschep 👌

LGTM :shipit:

@pmuens pmuens merged commit eef96aa into master Jan 25, 2019

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.006%
Details

@pmuens pmuens deleted the provided-template branch Jan 25, 2019

@dschep dschep added this to In progress in Serverless via automation Feb 5, 2019

@dschep dschep added this to the 1.36.4 milestone Feb 5, 2019

@pmuens pmuens moved this from In progress to Done in Serverless Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment