New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to aws-sdk v2.373.0 #5587

Merged
merged 1 commit into from Dec 12, 2018

Conversation

Projects
None yet
2 participants
@joshuanapoli
Copy link

joshuanapoli commented Dec 11, 2018

What did you implement:

Closes #3833

Projects using AWS have some trouble using AWS CLI profiles. While support for profiles is now baked into the serverless framework, the version locked for the aws-sdk package has bugs with using profiles.

How did you implement it:

Creating/checking the S3 bucket for a new project would fail during sls deploy, due to some problem in aws-sdk. Updating the aws-sdk package avoids the bug.

How can we verify it:

Using serverless 1.34.1, linked to aws-sdk 2.239.1, sls fails to deploy a project for the first time while using an AWS Profile with MFA.
image

After upgrading to aws-sdk 2.373.0, sls succeeds to deploy the project for the first time using the AWS Profile with MFA.
image

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@dschep

dschep approved these changes Dec 12, 2018

@dschep dschep merged commit 898e876 into serverless:master Dec 12, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 90.772%
Details

@dschep dschep referenced this pull request Dec 12, 2018

Merged

v1.35.0 release! #5592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment