Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore support for variable refs with spaces in them #5594

Merged
merged 2 commits into from Dec 13, 2018

Conversation

@dschep
Copy link
Contributor

dschep commented Dec 13, 2018

What did you implement:

Restores ability to have spaces in variable refs which was broken by #5571

How did you implement it:

if the variable being cleaned isn't surrounded by " white space is stripped as it was before

How can we verify it:

make a config file with a variable reference with a space in it

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@dschep dschep requested a review from pmuens Dec 13, 2018
Copy link
Member

pmuens left a comment

LGTM! :shipit:

@pmuens
pmuens approved these changes Dec 13, 2018
@dschep dschep merged commit 81e911e into master Dec 13, 2018
3 of 5 checks passed
3 of 5 checks passed
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.005%) to 90.777%
Details
@dschep dschep deleted the restore-space-support-to-variables branch Dec 13, 2018
@exoego exoego mentioned this pull request Feb 2, 2019
7 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.